newsfeeds: Ad-flag not honoured?

Russ Allbery rra at stanford.edu
Sat Jul 19 19:28:05 UTC 2008


Julien ÉLIE <julien at trigofacile.com> writes:

> I believe this patch fixes it (at least, it seemed to work well
> when I tested):
>
> --- innd/art.c  (révision 7932)
> +++ innd/art.c  (copie de travail)
> @@ -1709,7 +1709,7 @@
>       !DISTwantany(sp->Distributions, list))
>       /* Not in the site's desired list of distributions. */
>       continue;
> -    if (sp->DistRequired && list == NULL)
> +    if (sp->DistRequired && list != NULL && *list == NULL)
>       /* Site requires Distribution header and there isn't one. */
>       continue;
>
> It is a "char **list".
>
> Maybe should I put (list == NULL) || (list != NULL && *list == NULL)
> or only the second one is enough?

sp->DistRequired && (list == NULL || *list == NULL)

is probably the safest.

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>

    Please send questions to the list rather than mailing me directly.
     <http://www.eyrie.org/~eagle/faqs/questions.html> explains why.


More information about the inn-workers mailing list