DESTDIR support is broken (patch)

Julien ÉLIE julien at trigofacile.com
Fri Jun 6 06:22:09 UTC 2008


Hi Ivan,

> > +       if [ -r $D$(MAN5)/../man8 ] ; then \
>
> I'd rather use [ $D$(MAN5)/../man8 -ef $D$(MAN8) ] here, but
> unfortunately `-ef' isn't required by POSIX.
>
> Also, it might be something like:
>
>   if [ $(dir $(MAN5))/$(notdir $(MAN8)) = $(MAN8) ] ; then ...
>
> though I don't know whether these Make functions are portable.

Well, I can do:

    if [ "$D$(MAN5)/../man8" = "$D$(MAN8)" ] && [ -d $D$(MAN5)/../man8 ] ; then \

It will be like your suggested "-ef" (less efficient but still).



> It'll break in the following case:
>
> # ls -d /foo/man/man5
> /foo/man/man5
> # make MAN5=/foo/man/man5.my MAN8=/foo/man/man8.my install

This new test condition (= && -d) will not break in this case.

-- 
Julien ÉLIE

« Mon père, ce héros au sourire si doux. » (Victor Hugo) 



More information about the inn-workers mailing list