pullnews - bugfix, wishlist, new features

Geraint Edwards gedge-lists-inn-workers at yadn.org
Sun Jun 8 09:03:28 UTC 2008


Two minor issues resolved with this patch to pullnews.

- an off-by-one error on the limit to the amount of articles to get
- when an article is not available, we may have redundantly retried that article



--- pullnews.in.7855	2008-06-08 09:50:22.000000000 +0100
+++ code/pullnews-g8	2008-06-08 09:51:52.000000000 +0100
@@ -582,9 +582,9 @@
     my $i;
     my @warns;
     for ($i = ($first > $high ? $first : $high + 1) ; $i <= $last ; $i++) {
+        last if defined $maxArts and $count >= $maxArts;
+        last if defined $opt_f and $count >= $toget;
         $count++;
-        last if defined $maxArts and $count > $maxArts;
-        last if defined $opt_f and $count > $toget;
         sleep $opt_z if defined $opt_z and $count > 1;
         my $article = $fromServer->article($i);
         if ($article) {
@@ -793,6 +793,7 @@
 
             $shash->{$group} = [ time, $high = $i ];
         } else {
+            $shash->{$group} = [ time, $high = $i ] if $fromServer->code() == 430;    # no such article, do not retry
             print LOG "x" unless $quiet;
             printf LOG ("\nDEBUGGING $i %s %s\n", $fromServer->code(),
                         $fromServer->message()) if $debug >= 2;

-- 
Geraint A. Edwards (aka "Gedge")
gedge at yadn.org


More information about the inn-workers mailing list