Some interesting stuff from PLD
Julien ÉLIE
julien at trigofacile.com
Mon May 5 09:49:23 UTC 2008
Hi,
Manually browsing their CVS, I saw some patches which should perhaps
be included in TRUNK:
inn.conf
--------
-verifycancels: false
+verifycancels: true
-allownewnews: true
+allownewnews: false
-clienttimeout: 600
+clienttimeout: 1800
-innwatchspoolspace: 8000
+innwatchspoolspace: 25000
-nicekids: 4
+nicekids: 0
-docnfsstat: false
+docnfsstat: true
What do you think of these?
Maybe allownewnews should be kept to true and docnfsstat to false by default
but I think the other parameters can be modified.
> +# note: must not be changed to false if using tradspool
> storeonxref: true
Why "mustn't" it be set to false with tradspool?
readers.conf
------------
auth "localhost" {
- hosts: "localhost, 127.0.0.1, stdin"
+ hosts: "localhost, 127.0.0.1, ipv6-localhost, ::1, stdin"
default: "<localhost>"
}
I think it should be committed for IPv6.
Makefiles
---------
http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SOURCES/inn-asneeded.patch?rev=1.1;content-type=text%2Fplain
It disables -as-needed for binaries using libstorage (there is circular libstorage<>libinnhist dependency).
Something like that:
-archive: archive.o $(BOTH) ; $(LINK) archive.o $(STORELIBS)
+archive: archive.o $(BOTH) ; $(LINK) archive.o -Wl,-no-as-needed $(STORELIBS)
Is it a good idea to commit that?
configure.ac
------------
-AC_CHECK_HEADERS(crypt.h inttypes.h limits.h ndbm.h pam/pam_appl.h stdbool.h \
+AC_CHECK_HEADERS(crypt.h inttypes.h limits.h pam/pam_appl.h stdbool.h \
stddef.h stdint.h string.h sys/bitypes.h sys/filio.h \
sys/loadavg.h sys/param.h sys/select.h sys/sysinfo.h \
sys/time.h unistd.h)
Is it a good idea to commit that?
Regards,
--
Julien ÉLIE
« -- Vous croyez qu'on s'est fait rouler, chef ?
-- P'têt ben qu'oui, p'têt ben qu'non... » (Astérix)
More information about the inn-workers
mailing list