innbind fatal error

[Julien ÉLIE]

Hi Russ,

> 11119 sounds like the test suite.  Did you run make check?  Maybe there's
> something in the test suite that isn't redirecting logging output
> correctly.

Oh, thanks for the hint!
(By the way, innfeed should not interfere with innbind so I was looking
in the wrong direction.)


I now understand what is going on.

In order to reproduce the issue:

    ./configure --enable-ipv6
    make
    make check
    ./configure
    make
    make check

and it generates:

    lib/network.............MISSED 4-117 (exit status 1)
    overview/api............MISSED 2-75 (killed by signal 11)
    overview/buffindexed....MISSED 1-21 (exit status 1)
    overview/tradindexed....MISSED 2-21 (killed by signal 11)
    overview/xref...........MISSED 1-37 (killed by signal 11)
    util/innbind............MISSED 9-15; FAILED 6-7 (killed by signal 14)

    10:23 news at trigofacile ~/work/inn/trunk/tests/lib% ./network.t
    117
    ok 1
    ok 2
    ok 3
    cannot bind ::1,11119: not built with IPv6 support
    cannot create socket: Illegal seek
    zsh: exit 1     ./network.t

    10:24 news at trigofacile ~/work/inn/trunk/tests/util% ./innbind.t
    15
    ok 1
    ok 2
    ok 3
    ok 4
    ok 5
    innbind: unknown protocol family 10 in 3,10,::,11119
    read failed (return 0): Illegal seek
    not ok 6
    not ok 7
    ok 8
    connect failed: Connection refused
    zsh: alarm      ./innbind.t


Overview tests segfault.


I think it is because "make depend" is missing in the test suite but
it does not seem easy to add in test/Makefile...
The test suite is not entirely recompiled and innbind.t has tests for IPv6
which are not handled by innbind.c the second time...

lib/network.c only emits a warning and backends/innbind.c a fatal message
to LOG_CRIT.


Maybe message_handlers_die() should be added to libtest.c (which only
captures notice and warn).  But it does not solve the issue of dependencies.
So maybe "make check" should run "$(MAKE) clean && $(MAKE) build && ./runtests TESTS",
which would solve the whole problem (it does not affect only innbind).

-- 
Julien ÉLIE

« Il buvait toutes mes paroles, et comme je parlais beaucoup,
  à un moment, je le vois qui titubait... » (Raymond Devos)