PATCH: nnrpd/tls.c - fix stack overflow

Julien ÉLIE julien at trigofacile.com
Thu May 22 18:41:00 UTC 2008


Hi Chris,

> Please consider the following patch for nnrpd/tls.c.  It should apply to
> inn-2.4.2 through 2.4.4.

Thanks.  I have just committed it to CURRENT and will do it soon for STABLE.


> When an article of a size greater than remaining stack are retrieved via
> SSL, a segmentation fault will occur due to the use of alloca().

By the way, alloca is currently used only in nnrpd:  once in tls.c (but you
removed it) and once in nnrpd.c with an alloca_free(), that is to say an alloca(0).
But this one shouldn't be harmful, should it?

-- 
Julien ÉLIE

« 21.1.1 How to convert mSQL tools for MySQL?
   1. Run the shell script msql2mysql on the source.  This requires the
      replace program, which is distributed with MySQL.
   2. Compile.
   3. Fix all compiler errors. »                     (MySQL online manual)



More information about the inn-workers mailing list