DESTDIR support is broken (patch)

Julien ÉLIE julien at trigofacile.com
Fri May 23 16:21:58 UTC 2008


Hi Ivan,

> >> + $(LN_S) $(MAN8)/docheckgroups.8 $D$(MAN5)/localgroups.5
> >> + $(LN_S) $(MAN8)/perl-nocem.8 $D$(MAN5)/nocem.ctl.5
>
> > I think $D is missing in the first occurrence of the last two lines.
>
> With the code above, the symbolic links will be dangling after $
> make install, but will become valid as soon as the tree is
> copied to the actual installation location.  On the other hand,
> would `$D' be added to the first arguments of $(LN_S), the
> symbolic links would be valid after $ make install, but will
> become dangling upon the actual installation.

All right, thanks for the explanation.

Then I assume this line which comes afterwards:
    cd $D$(MAN8) && $(LN_S) actsync.8 actsyncd.8
should in fact be:
    $(LN_S) $(MAN8)/actsync.8 $D$(MAN8)/actsyncd.8


Just committed.  DESTDIR support should now work again.

-- 
Julien ÉLIE

« Aequum est ut cuius participauit lucrum, participet et damnun. »



More information about the inn-workers mailing list