[PATCH 1/2] CNFSv4: move to 4K blocksize (inn-CURRENT)

Julien ÉLIE julien at trigofacile.com
Wed Nov 26 21:11:44 UTC 2008


Hi Miquel,

> --- t/inn-CURRENT-20081125/frontends/cnfsstat.in 2008-11-25 11:01:10.000000000 +0100
> +++ inn-CURRENT-20081125/frontends/cnfsstat.in 2008-11-26 09:32:07.509345924 +0100
> @@ -431,8 +431,9 @@
>  exit(1);
>     }
>
> -    ($magic, $name, $path, $lena, $freea, $updatea, $cyclenuma) =
> -     unpack("a8 a16 a64 a16 a16 a16 a16", $buff);
> +    ($magic, $name, $path, $lena, $freea, $updatea, $cyclenuma, $metaname,
> +     $orderinmeta, $currentbuff, $blksza) =
> +     unpack("a8 a16 a64 a16 a16 a16 a16 a16 a16 a8 a16", $buff);
>
>     if(!$magic) {
>  print STDERR "Error while unpacking header ...\n";

You need:
    use vars qw($metaname, $orderinmeta, $currentbuff);
just before.

Otherwise, there is a problem with this script (launched with "perl -w" in the shebang
of CURRENT):

Name "main::orderinmeta" used only once: possible typo at /home/news/bin/cnfsstat line 435.
Name "main::currentbuff" used only once: possible typo at /home/news/bin/cnfsstat line 435.
Name "main::metaname" used only once: possible typo at /home/news/bin/cnfsstat line 434.


Thanks for your whole patch.  It works well.

-- 
Julien ÉLIE

« Les mathématiques peuvent être définies comme une science
  dans laquelle on ne sait jamais de quoi on parle, ni si ce qu'on dit
  est vrai. » (Bertrand Russell) 




More information about the inn-workers mailing list