Changes from upstream functions?
Julien ÉLIE
julien at trigofacile.com
Sat Sep 20 07:18:15 UTC 2008
Hi,
While reading nnrpd/tls.c, I found the following check:
if (ok==0)
{
syslog(L_NOTICE, "verify error:num=%d:%s", err,
X509_verify_cert_error_string(err));
if (verify_depth >= depth) {
ok = 0;
verify_error = X509_V_OK;
} else {
ok = 0;
verify_error = X509_V_ERR_CERT_CHAIN_TOO_LONG;
}
}
It looked weird to me that "ok = 0" was used twice.
As this function is taken from OpenSSL apps/s_cb.c, I checked it
and there is "ok = 1" for X509_V_OK.
My question is: how can we *easily* catch bug-fixes or improvements
for all the code we have in INN taken from other projects?
I do not see any obvious solution which is not very time-consuming...
--
Julien ÉLIE
« Et rose elle a vécu ce que vivent les roses :
L'espace d'un matin. » (François de Malherbe)
More information about the inn-workers
mailing list