innfeed - "blocked sleeping 120" errors"

[Julien ÉLIE]

Hi Petr,

> I am also concerned that:
>
> PID USERNAME THR PRI NICE   SIZE    RES STATE  C   TIME   WCPU COMMAND
> 865 news       1  97    0   380M   313M select 1  22.3H  7.81% innd
> 74712 news     1  97    0   259M   257M select 1 216:57  4.30% innfeed
> 74713 news     1  96    0   491M   489M select 1 177:02  2.54% innfeed
> 74714 news     1  96    0 17796K 15760K select 0  64:43  0.34% innfeed
>
> innfeed-current uses a very large amount of memory.
>
> I have conducted several tests in our test lab, but I could not get a
> memory leak..

Maybe it could become from a thing I fixed on 28 March 2009:

Remove useless xstrdup() calls in vector_add().  Memory has been
leaking in both innfeed (since commit 8176) and nnrpd (since
a long time).

Index: C:/Users/Julien/Downloads/svn/INN/trunk/innfeed/host.c
===================================================================
--- C:/Users/Julien/Downloads/svn/INN/trunk/innfeed/host.c (revision 8393)
+++ C:/Users/Julien/Downloads/svn/INN/trunk/innfeed/host.c (revision 8394)
@@ -3369,20 +3369,20 @@
   if (host->ipAddrs) {
     int  i;
     char ip_addr[INET6_ADDRSTRLEN];
-    char *family;
+    const char *family;

     for(i = 0; host->ipAddrs[i] != NULL; i++) {
       switch(host->ipAddrs[i]->sa_family) {
         case AF_INET:
-          family = xstrdup("IPv4");
+          family = "IPv4";
           break;
 #ifdef HAVE_INET6
         case AF_INET6:
-          family = xstrdup("IPv6");
+          family = "IPv6";
           break;
 #endif
         default:
-          family = xstrdup("????");
+          family = "????";
           break;
       }


Could you please try it?  Though it should probably not eat 300 MB if leaking!

Incidentally, here are the changes for innfeed since INN 2.4.0:

    http://inn.eyrie.org/trac/log/trunk/innfeed/?action=stop_on_copy&mode=stop_on_copy&rev=8394&stop_rev=6300


I do not know what could have generated a problem here.  It is perhaps not
something in this directory but in common INN libraries (?)

-- 
Julien ÉLIE

« Il faut que j'en parle à notre chef ; ce n'est pas normal que des Romains
  bravent les dangers de la forêt, surtout quand les dangers, c'est nous ! » (Astérix)