INN 2.5, inn-CURRENT-20090103 Issues

[Julien ÉLIE]

Hi William,

>> -      if (!cxnCheckstate (cxn))
>> +      if (cxn != NULL && !cxnCheckstate (cxn))
>
> I hate to say it but the patch isn't working.  I am still getting:
> 2009-01-05 23:19:38 innfeed: assertion -- cxn != NULL -- failed in file connection.c line 1171
> 2009-01-05 23:59:42 innfeed: assertion -- cxn != NULL -- failed in file connection.c line 1171
>
> Wish I had some suggestions.

The first thing cxnCheckstate() does is:

  ASSERT (cxn != NULL);

That function is called only once in innfeed, exactly where it
was patched.  I do not understand how cxn can be NULL here if we
check (cxn != NULL && !cxnCheckstate (cxn)).
It looks as though the second part of the condition were executed
before the first part, but it is not possible in C (AFAIK).

I am sorry I have no clue about that issue.  Has anyone a hint?

I assume you do not have several instances of innfeed running
and that all of them were closed when you updated INN with that patch.

-- 
Julien ÉLIE

« -- Ce serait une joyeuse idée de faire une tempête dans nos cerveaux, n'est-il pas ?
  -- Il veut parler d'une réunion de dravail ! » (Astérix)