Ticket #90 (innreport mishandles leap years)

Julien ÉLIE julien at trigofacile.com
Fri Jan 9 18:43:28 UTC 2009


Hi Alexander,

Thanks for your patch!


> +  confess "Invalid date $T" unless($m);
> +  confess "Invalid month name in $T" unless($m);

Would it be possible not to make innreport die when confess is called?


My favourite news.notice.test file:

Dec 31 19:27:55 news innd: ME status seconds 147396 accepted 3217 refused 11238 rejected 12 duplicate 0 accepted size 3885778 
duplicate size 0 rejected size 21506
Jan  9 19:27:58 news innd: news.matabio.net status seconds 23306 accepted 1 refused 1350 rejected 0 duplicate 0 accepted size 2018 
duplicate size 0 rejected size 0


% ./innreport -f ~/etc/innreport.conf ~/news.notice.test
Invalid date  at ./innreport line 704
        main::ConvDate('undef') called at ./innreport line 506


It previously worked, but gave an empty date:
news-notice.2008.01.09-19.27.58.html|Jan  9 19:27:58 -- |0|0|0.0 KB|0|0|0.0 KB


With a third line in news.notice.test, I have:
news-notice.2008.01.09-19.27.58.html|Jan  9 19:27:58 -- Dec 31 19:27:57|0|0|0.0 KB|0|0|0.0 KB

Where 19:27:57 is the date of the second line.
Hmm...  It looks as though the first line is not taken into account as for the date.


Anyway, that issue is not linked to your patch (which works pretty well).

-- 
Julien ÉLIE

« Toi, quand tu serres la main, tu n'y vas pas de main morte ! » (Astérix)




More information about the inn-workers mailing list