Ticket #90 (innreport mishandles leap years)

Alexander Bartolich alexander.bartolich at gmx.at
Sat Jan 10 00:58:36 UTC 2009


Julien ÉLIE wrote:
> [...]
> Would it be possible not to make innreport die when confess is called?
 >
 > My favourite news.notice.test file:
 >
 > Dec 31 19:27:55 news innd: ME status seconds 147396 accepted 3217 refused 11238 rejected 12 duplicate 0 accepted size 3885778 duplicate size 0 rejected size 21506
 > Jan  9 19:27:58 news innd: news.matabio.net status seconds 23306 accepted 1 refused 1350 rejected 0 duplicate 0 accepted size 2018 duplicate size 0 rejected size 0

Hmm. Did not think it was that easy to trigger the condition.
Well, previously ConvDate returned -86400 for invalid date strings.
And invalid month names were mapped to January.

As far as I see the code calling ConvDate does not check for negative
return values. Perhaps that's the cause of ticket #41 (innreport creates
incorrect file names at the start of the year).

Ciao

     Alexander.



More information about the inn-workers mailing list