Checkgroups handling

[Julien ÉLIE]

Hi,

There are a few patterns which do not work with INN 2.4 as for
checkgroups processing.

Suppose we have the following newsgroups in a checkgroups:

  comp.binaries
  comp.foo.bar
  news.foo
  news.foo.bar

And now in control.ctl:

1/
  checkgroups:from:comp.*:verify-...
  checkgroups:from:news.*:doit

How should we handle that?  Is it OK to use the most restrictive situation
for the *whole* checkgroups, that is to say "verify" here, for both comp.*
and news.*?
Or, something that would be better, should we process the checkgroups twice?
(One time for comp.* [minus possible dropped newsgroups] and another time
for news.* [minus possible dropped newsgroups] alone?)
Any other suggestions?

With INN 2.4, only the news.* part would be done and comp.* not treated at all.


2/
  checkgroups:same-from:foo.*:verify-key-foo
  checkgroups:same-from:bar.*:verify-key-bar

Processing twice the checkgroups will allow the same sender to use two
different keys.

This currently cannot be done with INN 2.4.
With INN 2.5, one will "pgpfail" and the other one will be properly verified.


3/
  checkgroups:from:comp.*,news.*:verify-...
  checkgroups:*:*binaries*:drop

In the new system for INN 2.5, I suggest that all control.ctl
entries be checked.  Not only the last matching one.  It will
then allow to drop the first newsgroup from the checkgroups.
The order of the "drop" and "verify" matters:  here, it drops
comp.binaries (otherwise, if "drop" is before, it will not impact
this checkgroups, but the previous ones in control.ctl).

Does it sound OK?

Note that if comp.binaries must not be removed (contrary to other.binaries),
the <pathetc>/localgroups file also permits to exclude it from the list.


4/
  checkgroups:*:*:mail

This default entry in control.ctl is bothering.  I suggest that we do not
process it if a line other than "drop" has already matched the checkgroups.

  checkgroups:*:*:mail
  checkgroups:*:foo.*:drop

will result with foo.* entries being dropped.  Then the body of the
checkgroups is empty (if for foo.*) and it will not be mailed.
But bar.* will because the body of the checkgroups is not empty after
the drop.


5/
  Do you see other control.ctl issues?


-- 
Julien ÉLIE

« [...] cette sombre superstition qui porte les âmes faibles
  à imputer des crimes à quiconque ne pense pas comme elles. » (Voltaire)