TAKETHIS rejects in logs

[Julien ÉLIE]

Hi,

In <pathlog>/news, we log IHAVE rejects (437) but not TAKETHIS rejects (439).
Is there a reason for that or is it an oversight?

innreport also only checks for "437 error message".


Incidentally, thanks to Petr Novopashenniy, I have just discovered that
the count of rejects with TAKETHIS was not done in INN 2.5.
There is an easy fix in ARTreject():

Index: art.c
===================================================================
--- art.c       (révision 8382)
+++ art.c       (copie de travail)
@@ -1123,6 +1123,12 @@

   cp->Rejected++;
   cp->RejectSize += cp->Next - cp->Start;
+
+  /* Streaming is used. */
+  if (cp->Sendid.size > 3) {
+    cp->Takethis_Err++;
+  }
+
   switch (code) {
     case REJECT_DUPLICATE:
       cp->Duplicate++;



Now I have after:

CHECK <bad@
438 <bad@
CHECK <good at id>
238 <good at id>
TAKETHIS <good at id>
bad article
.
439
IHAVE <bad@
435 Bad Message-ID
IHAVE <good at id>
335
bad article
.
437 No body


localhost
 ip address: 127.0.0.1
    seconds: 42             duplicates: 0     max allowed cxns: 8
    offered: 2           uw newsgroups: 0          active cxns: 1
   accepted: 0        uw distributions: 0        sleeping cxns: 0
    refused: 0              unapproved: 0       want streaming: Yes
   rejected: 2                filtered: 0         is streaming: Yes
       size: 0.0kb           bad sites: 0       duplicate size: 0.0kb
reject size: 0.0kb
  Protocol:
      Ihave: 2      SendIt[335]: 1         Got[435]: 0      Deferred[436]: 0
      Check: 2      SendIt[238]: 1         Got[438]: 0      Deferred[431]: 0
   Takethis: 1          Ok[239]: 0       Error[439]: 1


I think this part of innd_status file looks right.

-- 
Julien ÉLIE

« La médecine est un métier dangereux. Ceux qui ne meurent pas
  peuvent vous faire un procès. » (Coluche)