Static variables in NCproc for parsing

Julien ÉLIE julien at trigofacile.com
Fri Nov 6 23:11:59 UTC 2009


Hi Russ,

>> I've added a *static* variable "av" because Argify uses xstrdup and we
>> need to properly free what it created last time it was called.  I think
>> it works because innd reads its channels one by one, in sequence.
>> Otherwise, memory will leak.
>
>> Is it the right thing to do for "ac" and "av"?
>
> The extra persistant state that we're recording per channel should really
> be stored in the channel struct in innd.  I would add an additional
> variable to the channel struct; I think it will be visible in all the
> places that you need it.


OK, just done.
I also added code in CHANclose() in order to properly free that variable.

-- 
Julien ÉLIE

« Je ne suis ni pour ni contre, bien au contraire ! » (Coluche) 




More information about the inn-workers mailing list