innconf test

[Julien ÉLIE]

Hi Heiko,

First of all, thanks for your patches.


> 1. It will fail it hostname does not contain a domain and DNS lookup also
>   does not contain a dot (e.g. host defined in /etc/hosts just with name):
>
> hostname does not resolve or domain not set in inn.conf
>    and
> string variable fromhost differs: NULL != ech
> ("ech" is the hostname)
>
>   Of course, inn needs a FQDN to operate but this could be defined in
>   inn.conf ("domain"). Therefore the innconf test should not fail with
>   inn.conf of samples directory. Maybe it would be better to provide
>   one or more special inn.conf variants for running tests and not use the
>   one generated in samples directory.

I think the goal is to be sure that the inn.conf we shipped with INN
is correct.  So I believe we still should check the one in the samples
directory.

The same way we generate an inn.conf file with egrep for runnning tests,
we could generate an inn.conf file with domain and fromhost set to
"news.example.org".
I believe it would fix the two problems you report above.

Is it fine for you if I do that?



> 2. Regular expression in egrep should only match at the beginning of lines
>
>   Otherwise "./configure --prefix=/opt/portable" will fail on test 8
>   because additional lines matches "port".
>
>   Without the patch test 8 also depend on comment lines which is somewhat
>   ugly too.

You're totally right.  Thanks!

-- 
Julien ÉLIE

« En fait, je n'ai qu'une prétention, c'est de ne pas
  plaire à tout le monde. Plaire à tout le monde, c'est plaire
  à n'importe qui. » (Sacha Guitry)