[patch] actsync rejects hannover._wichtig

Julien ÉLIE julien at trigofacile.com
Thu Mar 18 20:21:06 UTC 2010


> Incidentally, I do not understand well the part of the code you changed:
> couldn't isascii(*(p+1)) be removed because of isalnum((int)*(p+1)) just
> afterwards?

Hmm...  I read in our include/clibrary.h:

/* On some systems, the macros defined by <ctype.h> are only valid on ASCII
   characters (those characters that isascii() says are ASCII).  This comes
   into play when applying <ctype.h> macros to eight-bit data.  autoconf
   checks for this with as part of AC_HEADER_STDC, so if autoconf doesn't
   think our headers are standard, check isascii() first. */
#if STDC_HEADERS
# define CTYPE(isXXXXX, c) (isXXXXX((unsigned char)(c)))
#else
# define CTYPE(isXXXXX, c) \
    (isascii((unsigned char)(c)) && isXXXXX((unsigned char)(c)))
#endif



Is that behaviour still true today?

I see that we're using isalnum() or isdigit() without calling isascii()
first at other places of the code...
Should we fix something for that?


Another question:  is our isXXXXX() really working?!?
Shouldn't we put several lines for isdigit(), isalnum(), etc.?

-- 
Julien ÉLIE

« Plus un ordinateur possède de RAM, plus vite il peut générer un message d'erreur. » 




More information about the inn-workers mailing list