tests/overview/xref.t failing

Julien ÉLIE julien at trigofacile.com
Sat Sep 25 23:25:35 UTC 2010


Hi Wim,

>> Did you notice, on real use, problems with your overview and accessing
>> articles?  As the high water mark is always increased, you should not
>> worry... unless you are in an Xref slave mode...
>
> In real use, I'm using ovdb. :) I agree that the problem doesn't seem like
> it would crop up very often in normal use. Though I suppose that's why
> there is a test suite.

:-)


And did you try to remap the index file this way on your system?
With the following patch, does the test suite work?
(If yes, I can rewrite the code to remap only when mmap misses writes.)


Index: tdx-data.c
===================================================================
--- tdx-data.c  (révision 9112)
+++ tdx-data.c  (copie de travail)
@@ -462,14 +462,14 @@
         return NULL;

     if ((end > data->high && high > data->high) || data->remapoutoforder) {
-        data->remapoutoforder = false;
         unmap_data(data);
     }
-    if (end > data->high && high > data->high) {
+    if ((end > data->high && high > data->high) || data->remapoutoforder) {
         unmap_index(data);
         map_index(data);
         data->high = high;
     }
+    data->remapoutoforder = false;

     if (start > data->high)
         return NULL;


-- 
Julien ÉLIE

« -- On nage dans le lac, on escalade les montagnes...
  -- Ben quoi ? Nous ne sommes pas en vacances ! » (Astérix) 




More information about the inn-workers mailing list