Call for inncheck testing

Florian Schlichting fschlich at CIS.FU-Berlin.DE
Tue Aug 2 16:21:50 UTC 2011


Hi,

On Sun, Jul 10, 2011 at 09:55:18PM +0200, Julien ÉLIE wrote:
> > news at newsreader5:~$ perl bin/inncheck -pedantic
> > /usr/local/news/etc/newsfeeds:0: warning you accept all incoming article distributions
> 
> I am wondering whether this warning is really useful nowadays.

...

> Maybe we should drop this warning.  No need for "ME" at all.
> Any thoughts about that?

we've been running with "ME:::" and the following patch for years,
without problems. So: yes, absolutely.

Florian


@@ -694,7 +694,7 @@ my %newsfeeds_flags = (
 sub
 newsfeeds
 {
-    my ($next, $start, $me_empty, @muxes, %sites);
+    my ($next, $start, @muxes, %sites);
     my ($site, $pats, $dists, $flags, $param, $type, $k, $v, $defsub);
     my ($bang, $nobang, $prog, $dir);
     my (%variables, $key);
@@ -769,8 +769,6 @@ newsfeeds
        if $flags ne "";
        eprint "$file:$start: ME param should be empty\n"
        if $param ne "";
-           $me_empty = 1
-               if $pats !~ "/.+";
    }
 
    ##  If we don't have !junk,!control, give a helpful warning.
@@ -846,8 +844,8 @@ newsfeeds
    eprint "$file:$_\n"
        if /`(.*)'/ && !defined $sites{$1};
     }
-    eprint "$file:0: warning you accept all incoming article distributions\n"
-       if !defined $sites{"ME"} || $me_empty;
+    eprint "$file:0: manpage says there must be exactly one ME entry\n"
+       if !defined $sites{"ME"};
 
     print "done.\n"
    if $verbose > 0;



-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5557 bytes
Desc: not available
URL: <https://lists.isc.org/pipermail/inn-workers/attachments/20110802/54dbd6a6/attachment.bin>


More information about the inn-workers mailing list