Case-insensitive tokens

Russ Allbery rra at stanford.edu
Sat Aug 6 02:39:29 UTC 2011


Julien ÉLIE <julien at trigofacile.com> writes:

> I suggest the following patch:

>  * checking that the last argument to "ctlinnd addhist"
>    is either '' or a valid token;

>  * using @000000000000000000000000000000000000@ when the token
>    is empty ('') for "ctlinnd addhist" or badly formatted for
>    any other function calling TextToToken();

>  * fixing the result of the hexadecimal conversion when a lowercase
>    character is used.  Transform it to an uppercase character.

Those all look like a good idea to me.

> Should we go on accepting case-insensitive tokens (transforming them
> into uppercase chars), or should we reject lowercase hex values?

> As it is not the same value ('a' != 'A'), it gives different results in
> our conversion routines.  That's why maybe it would be wiser to reject
> lowercase tokens.

I can't imagine anyone typing these in by hand rather than cutting and
pasting them, and they're intended to be opaque identifiers.  It might be
simpler to just reject lowercase.

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>

    Please send questions to the list rather than mailing me directly.
     <http://www.eyrie.org/~eagle/faqs/questions.html> explains why.



More information about the inn-workers mailing list