procbatch

[Florian Schlichting]

On Tue, Aug 23, 2011 at 11:45:29PM +0200, Florian Schlichting wrote:
> tonight I got around to finishing the procbatch manual page, which
> you'll find attached. And if you can be bothered, here's a typo and two
> redundant lines that I happened upon while looking for documentation:

I just wondered if we should perhaps check if -s / -t are being used
without -c /-m, and report an error (warn? die?) in that case?

--- a/innfeed/procbatch.in
+++ b/innfeed/procbatch.in
@@ -3,12 +3,10 @@
 
 # Author:       James Brister <brister at vix.com> -- berkeley-unix --
 # Start Date:   Thu May 16 10:32:02 1996 +0200
-# Project:      INN -- innfeed
-# File:         procbatch.pl
 # RCSId:        $Id$
 #
 # Description: Take a file of the form generated by innd in the outgoing
-#             directory ("Wnm*") and separate it into tape files for INN.
+#             directory ("Wnm*") and separate it into tape files for innfeed.
 #
 # Thanks to Clayton O'Neill <coneill at premier.net> for serious speed
 # improvements. 
@@ -81,6 +79,8 @@ unless (-f $inputFile) {
 die "No such directory: $spoolArts\n\n" . $usage if ( ! -d $spoolArts && $opt{'c'} );
 die "No such directory: $destDir\n\n"   . $usage if ( ! -d $destDir );
 die "No such directory: $tapeDir\n\n"   . $usage if ( ! -d $tapeDir && $opt{'m'} );
+warn "Specifying -s without -c has no effect!" if $opt{'s'} and not $opt{'c'};
+warn "Specifying -t without -m has no effect!" if $opt{'t'} and not $opt{'m'};
 
 print "Using $inputFile\n" if $opt{'v'};
 open (my $INPUT, '<', $inputFile) || die "$0: open ($inputFile): $!\n";



and then perhaps the manpage SYNOPSIS should read:

> =head1 SYNOPSIS
> 
> B<procbatch> [B<-e> I<peer>] [B<-d> I<outdir>] [B<-c>] [B<-s> I<spooldir>]
> [B<-m>] [B<-t> I<backlogdir>] [B<-u>] F<batchfile>

B<procbatch> [B<-e> I<peer>] [B<-d> I<outdir>] [B<-c> [B<-s> I<spooldir>]]
[B<-m> [B<-t> I<backlogdir>]] [B<-u>] F<batchfile>


Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5557 bytes
Desc: not available
URL: <https://lists.isc.org/pipermail/inn-workers/attachments/20110824/7cf33567/attachment.bin>