Moving servers

Julien ÉLIE julien at trigofacile.com
Thu Jul 7 11:47:27 UTC 2011


Hi Florian,

>>> if (strcmp(style, "authinfo") != 0) {
>>> errno = EDOM;
>>
>> ah, I didn't know that. But it's not a very telling error message, given
>> that we're not dealing with anything numeric here?! How about E2BIG,
>> 'Argument list too long'? (EINVAL is already used earlier)
>
> E2BIG seems far better, thanks.

OK, committed.


>> BTW inncheck doesn't catch this kind of error. Small improvement:
>>
>> - unless ( ($name, $pass) = /[\w\-\.]+:(.*):(.*)(:authinfo)?$/ ) {
>> + unless ( ($name, $pass) = /[\w\-\.]+:([^:]*):([^:]*)(:authinfo)?$/ ) {
>
> Thanks for the improvement.  I will commit it after your other pending
> patches for inncheck.

Now committed.
Good news:  all your patches for inncheck are now in CURRENT.

I will merge them into STABLE for the 2.5.3 release.

-- 
Julien ÉLIE

« – Rendre compte ? Mais nous n'y sommes pas allés et nous n'avons
     rien vu ! Et puis Jules César a dit…
   – Je ne sais pas ce que Jules César a dit, mais ne pas y aller et
     ne pas voir, c'est le meilleur moyen de ne pas être vaincus ! »
     (Olibrius)



More information about the inn-workers mailing list