Moving servers
Julien ÉLIE
julien at trigofacile.com
Fri Mar 4 10:45:05 UTC 2011
Hi Florian,
>> if (strcmp(style, "authinfo") != 0) {
>> errno = EDOM;
>
> ah, I didn't know that. But it's not a very telling error message, given
> that we're not dealing with anything numeric here?! How about E2BIG,
> 'Argument list too long'? (EINVAL is already used earlier)
E2BIG seems far better, thanks.
> ...or just convert passwd.nntp to the new configuration file syntax and
> parser, with detailed error messages and line numbers and...
Oh, yes, it would be the best solution :-)
(Not in top priority for passwd.nntp…)
> BTW inncheck doesn't catch this kind of error. Small improvement:
>
> - unless ( ($name, $pass) = /[\w\-\.]+:(.*):(.*)(:authinfo)?$/ ) {
> + unless ( ($name, $pass) = /[\w\-\.]+:([^:]*):([^:]*)(:authinfo)?$/ ) {
Or /[\w\-\.]+:(.*?):(.*?)(:authinfo)?$/ for ungreedy matching.
I have always wondered what is the most readable. Maybe your
[^:]* is the preferred way to write it in Perl.
Thanks for the improvement. I will commit it after your other pending
patches for inncheck.
--
Julien ÉLIE
« Bibere humanum est, ergo bibamus. »
More information about the inn-workers
mailing list