INN 2.5.3 release candidate

Russ Allbery rra at stanford.edu
Sat Oct 15 21:53:07 UTC 2011


Julien ÉLIE <julien at trigofacile.com> writes:

>> I'd do something like:
>> 
>>      if (serv == NULL)
>>          skip("biff service not found");
>>      else if (strcmp(serv, "comsat") == 0)
>>          is_string("comsat", service, "...and found biff");
>>      else
>>          is_string("biff", service, "...and found biff");

> It will give:

> ok 13 - lookup of 512 UDP
> ok 14 - ...and found biff

> in both cases.  Shouldn't the test for comsat return
> "...and found comsat"?

> The strcmp() function should use the "service" variable, in lieu of
> the "serv" struct variable.

Both good points.  Fixed in rra-c-util.

-- 
Russ Allbery (rra at stanford.edu)             <http://www.eyrie.org/~eagle/>

    Please send questions to the list rather than mailing me directly.
     <http://www.eyrie.org/~eagle/faqs/questions.html> explains why.



More information about the inn-workers mailing list