cant store article: bogus Xref: header in INN 2.5 ?

[Julien ÉLIE]

Hi Matija,

>> I believe we need a complete fix for all the uses of the Xref: header
>> field.  I came up with a partial patch, only fixing the issue you
>> mentioned.  However, other places should be fixed in the code.
>
> Would it work to fix this one reported issue and not lead to new
> problems? If so, can you send me that partial patch so I can see how
> it fares?

I still haven't fixed the overview.  The article is properly stored in 
tradspool but not in the overview data (as Xref: header is not correctly 
parsed, no newsgroups exist for the overview data).



> I'd rather run with debian version + small patch, than to have to
> repackage whole latest version...

No need to repackage whole latest version.  It will also be a small 
patch.  Just a few skip_fws() at the /right/ places.



>> Other affected programs parsing Xref: header fields, are:
>> archive, expire, makehistory, overchan, and also nnrpd (because of
>> virtual hosting and NEWNEWS checks).
>
> oh, so fixing innd to receive Xref with extra space might then break
> nnrpd, expire, makehistory, etc? That is not very good, yes, and it
> would need complete fix or nothing..

Fixing the issue of leading spaces does not break these programs.  There 
are already broken.  Already integrated articles with INN 2.4.6 can 
contain leading white spaces in Xref: header field.  INN 2.5.2 does not 
deal with that; just rebuild the overview data of your slave, and you 
will lose the articles with leading white spaces (unrecognized).



> As a quick kludge, is it possible just for the "bogus Xref: header"
> error not to trigger periodic server throttling?  It would be a
> stopgap measure

I believe it would be way cleaner to reject these messages with your 
local cleanfeed on INN 2.5.2.


Isn't it a problem for you if your slave backup server does not have all 
the articles it should have?  If you don't mind dropping these "bogus" 
Xref: headers (that are in fact valid), just drop them; and wait for INN 
2.5.3 or INN 2.5.4 to thoroughly fix that.

-- 
Julien ÉLIE

« – Ils transportent une arme secrète dans un tonneau !
   – La cervoise tiède !!!
   – Non, ça c'est une arme connue. » (Astérix)