storeonxref and tradspool

[Julien ÉLIE]

Hi all,

The storage manager refuses to start when tradspool is used with 
storeonxref:

In tradspool_init():

     if (!innconf->storeonxref) {
         warn("tradspool: storeonxref needs to be true");
         SMseterror(SMERR_INTERNAL, "storeonxref needs to be true");
         return false;
     }



Yet, we have tradspool_next():

  if (innconf->storeonxref) {
...

  if (xrefhdr == NULL || !innconf->storeonxref) {
      ng = wire_findheader(art->data, art->len, "Newsgroups", true);
...


There is code to handle storeonxref with tradspool.  But it is not 
supported everywhere (CrackXref() is still called on the Newsgroups: 
header once, which obviously fails).


I do not find any place in our documentation that mentions an 
impossibility to use tradspool with storeonxref.  Should we mention it 
(and drop existing storeonxref code in tradspool) or should we try to 
make it work with tradspool?

-- 
Julien ÉLIE

« – Ils transportent une arme secrète dans un tonneau !
   – La cervoise tiède !!!
   – Non, ça c'est une arme connue. » (Astérix)