cant store article: bogus Xref: header in INN 2.5 ?

[Matija Nalis]

On Tue, Sep 13, 2011 at 10:11:02PM +0200, Julien ÉLIE wrote:
> >>I hope the above proposal of "fix" is fine for your needs.  INN 2.5.2 will
> >>work fine with it in xrefslave mode.
> >
> >I've patched the server, and so far it's been running without throttling for
> >36 hours, so it does look fixed (it used to throttle itself at least one a
> >day, usually few times a day).
> 
> OK, I'm glad to hear that good news!
> 
> I have also been running the patch for a few days without any issue.
> 
> Please note that the patch is actually required only for slaves.  It
> is not necessary to use it otherwise.  You will therefore be able to

Yes... Also, when I upgrade my newsfeed master to Debian 2.5.2-2~squeeze1
package, I will not need the patch even on xrefslave servers anymore, right? 
So I can downgrade them to standard Debian packages (in order not to have to
worry about security updates tracking etc).

> use your Debian 2.5.2-2~squeeze1 package without any changes for
> your upstream "newsfeed" server.

Well, not for this problem; however newsfeed innd had few extra patches
which I have to check if they're needed in 2.5.x -- there was something
having to do with In-Reply-To errors and I've been adding few more headers
to be available to perl filters...  Are in 2.5.2 all headers available in
%hdr{} or are there only still just a dozen hardcoded ones copied like in
2.4.6?  I know there were talks about that, but don't remember if that get
implemented...

Anyway, I'll check those when I get to that; so many things to do in between
while I let users hammer out this patched 2.5.2...

> The committed patch is:
>     http://inn.eyrie.org/trac/changeset/9376/trunk
> 
> with an (innconf->xrefslave && i == HDR__XREF) condition.

out of curiosity, why the extra "innconf->xrefslave" check? would always
checking for HDR__XREF break something if we weren't xrefslave ?

> >I'll leave it running with no load for couple more days, and then I'll turn
> >it back in the production to see how it fares.
> 
> Incidentally, did you manage to clean up the articles spool dir of
> your slave?
> I assume it was a great mess there with the previous broken patch...

Yes I did, thankfully it throttled itself soon enough due to "file exists"
errors...  mc(1) with "sort by change time" cleaned it up quite painlessly,
thankfully.

-- 
Opinions above are GNU-copylefted.