[PATCH] innfeed does not reopen (rotated) log file

Julien ÉLIE julien at trigofacile.com
Mon Apr 29 19:50:06 UTC 2013


Hi Florian,

> I revisited your earlier suggestion to add a call to openLogFile() to
> the sighup handler (sigusr1 is already used for increasing debug
> level), and this is what I'm successfully running with now:

Thanks for your proposal of patch.

I wonder whether sending the signal twice is necessary (once before the 
rotation, and once after the rotation).  Isn't it enough to send it 
after the rotation?

That is to say we keep a "ctlinnd flushlogs" before the rotation, and we 
add the innfeed signal after the rotation (instead of the second 
"ctlinnd flushlogs" introduced in a recent commit, that should be reverted)?

It would then be fine for INN 2.5.  And we could consider a complete fix 
for INN 2.6 with the addition of "ctlinnd prerotatelogs"/"ctlinnd 
postrotatelogs"?

-- 
Julien ÉLIE

« J'adore être pris en flagrant délire. » (Raymond Devos)


More information about the inn-workers mailing list