[PATCH] innfeed does not reopen (rotated) log file

Julien ÉLIE julien at trigofacile.com
Mon Jan 7 19:16:34 UTC 2013

Hi Russ,

>> In innfeed/main.c, there is an openLogFile() function that does a
>> freopen() of the innfeed log file.
>> Couldn't we just add a call to openLogFile() in the existing sighup()
>> function in main.c?  This sighup() function currently reloads
>> innfeed.conf and reconfigure hosts.
> Ah, yes, that sounds right to me.  That would indeed fix the problem, and
> I don't see any drawbacks to adding it to the existing sighup handler.
> That's quite a bit simpler than I was expecting!

The only issue I could think of is that the current sighup() function 
reloads innfeed.conf.  This file would therefore be reloaded everyday, 
which might cause a problem if it has changed and the news administrator 
still has not wanted to reload it.  An automatic reload of innfeed.conf 
would then have innfeed shut down (if for instance the syntax of the new 
innfeed.conf file is wrong).

Julien ÉLIE

« Ex nihilo nihil. » (Perse)

More information about the inn-workers mailing list