[PATCH] innfeed does not reopen (rotated) log file

Julien ÉLIE julien at trigofacile.com
Mon Jun 3 18:29:03 UTC 2013


Hi Florian,

> feel free to just commit whatever you think is reasonable.

I have just committed revision 9479 for STABLE (INN 2.5.4):
     http://inn.eyrie.org/trac/changeset/9479/branches/2.5

It runs fine on my news server.  Do not hesitate to tell if you see 
something wrong on yours.


The remaining issue was to properly flush channel / exploder feeds after 
rotation so that a deleted log/OLD/errlog was not kept open.  But isn't 
it already solved by the change in "ctlinnd flushlogs"?  This file is 
rotated and then channel and exploder feeds flushed.
Is the problem now only concerning "livefiles" like perl-nocem.log or 
controlbatch.log that are rotated after the feeds have been flushed, or 
do you believe something else needs fixing?

-- 
Julien ÉLIE

« A program should always respond to the user in the way that
   astonishes him least. » (Plauger's Law of Least Astonishment)


More information about the inn-workers mailing list