enableoverview to false

[Julien ÉLIE]

Hi John,

Replying to an old message (29/06/2012):
>> I will update the documentation to mention the fact.
>> Thanks again for your precious remarks!

Now done, and the updated man page for news.daily will
be shipped with INN 2.5.4, mentioning:

If the "lowmark" keyword is given to news.daily, then
the "expireover" keyword must also be given; otherwise,
that kind of renumbering will not be taken into account.



> I can report that simply renaming or moving ${OVERVIEWDIR} causes the 
> server to throttle when the 10-minute sanity check is performed:
> 
> Jun 26 02:09:08 optima11 innd: ctlinnd command s
> Jun 26 02:09:11 optima11 innd: ctlinnd command r:No space (overview) 
> [innwatch:43] 0 lt 25000
> Jun 26 02:09:11 optima11 innd: filter: Saved EMP database.
> Jun 26 02:09:11 optima11 innd: CNFS: CNFSflushallheads: flushing 004
> Jun 26 02:09:11 optima11 innd: SERVER throttled No space (overview) 
> [innwatch:43] 0 lt 25000
> 
> To fix it I created an empty overview directory instead of simply 
> commenting out line 43.

That's because "inndf /unexisting/path" is valid and returns 0, which
is considered by innwatch to be the available space left (0 kb).  It then
throttles the server.

innwatch.ctl should be fixed.
I suggest to modify
    !!! ${INNDF} ${OVERVIEWDIR} ! lt ! ${INNWATCHSPOOLSPACE} ! throttle ! No space (overview)
so as to use:
    !!! test -d ${OVERVIEWDIR} && ${INNDF} ${OVERVIEWDIR} ! lt ! ${INNWATCHSPOOLSPACE} ! throttle ! No space (overview)

This way, if the overview directory does not exist, the test fails and
is not executed.

Thanks again for your two reports.  They will both be fixed in INN 2.5.4.


If you know other nits like them, please tell me.  The 2.5.4 release
will be generated soon (probably this week-end).

-- 
Julien ÉLIE

« Et maintenant, passons à table. Toi aussi, mon fils ! » (César)