socket activation for INN
Russ Allbery
eagle at eyrie.org
Mon May 19 18:31:10 UTC 2014
md at Linux.IT (Marco d'Itri) writes:
> Would you accept a patch similar to this one?
> I have been using it for a while with inn 1.x and it works well.
> http://anonscm.debian.org/gitweb/?p=users/md/inn.git;a=commitdiff;h=a1ca667dd50b6578130f12a80512e3e8267b355a
This generally looks good to me. I particularly like the status
notification.
There are a few nits:
* Never use sprintf in new INN code. INN provides snprintf, which can be
used if there's no good way to structure the code to use asprintf.
asprintf is strongly preferred if it's possible to structure the code to
use it.
* rra-c-util provides portability for libsystemd-daemon, which should be
used instead of calling pkg-config directly and which will also handle
silent degredation if systemd isn't available. The logic in this patch
for innd will have to change a little to continue on with normal startup
if systemd is not available.
* INN should be able to listen to multiple sockets. We already configure
it that way now. I'm not sure what additional glue will be required.
rra-c-util may need some additional portability glue for sd_is_socket,
since I don't think I've needed that before.
Ideally, we should also use socket activation for the ctlinnd socket, but
that can wait until later.
--
Russ Allbery (eagle at eyrie.org) <http://www.eyrie.org/~eagle/>
Please send questions to the list rather than mailing me directly.
<http://www.eyrie.org/~eagle/faqs/questions.html> explains why.
More information about the inn-workers
mailing list