nnrpd given the same PID as innfeed

Julien ÉLIE julien at trigofacile.com
Wed Jun 17 20:26:17 UTC 2015


Hi Richard,

> Patch attached.  I've lightly tested it, including inspecting strace
> output while manually poking the system to check it's not gone
> completely off the rails.

Thanks for your patch.  I have been running it for a few hours without 
any problem.  I hope the race condition between signals now belongs to 
the past.


+        for(n = 0; n < signal_max; ++n)
+            if(sigismember(&signals_masked, n)
+               && !sigismember(&signals_unmasked, n))
+                signal(n, SIG_DFL);
+        /* Now it's OK to unblock signals we ha

Couldn't we use sigaction() with act.sa_handler=SIG_DLF, act.sa_mask 
empty (no need to have signals_masked here if I understand well) and 
act.sa_flags=SA_RESTART if available?
Elsewhere in the code, we do not use signal() when sigaction() is usable.

-- 
Julien ÉLIE

« – Avez-vous été attaqués par une force supérieure en nombre ?
   – Supérieure en nombre…
   – …On ne peut pas dire !
   – …Ils étaient un…
   – …Et pas bien gros avec ça ! » (Astérix)


More information about the inn-workers mailing list