Pending patches for INN?
Julien ÉLIE
julien at trigofacile.com
Sat May 23 12:06:26 UTC 2015
Hi Richard,
> I would suggest NOT delaying any release for my benefit - I devote time
> to this in very unpredictable ways.
OK, noted. Thanks again for your investment in improving
the robustness of INN.
Regarding your first patch for innxmit, shouldn't
static char *buff;
be changed to
static char *buff = NULL;
as you no longer use xmalloc, but only xrealloc?
If *buff is not initialized to NULL, it seems that it could
trigger an issue off with xrealloc trying to expand memory
from a wrong location.
As for actsync.c, maybe we could add the following test at the beginning
of get_active()?
@@ -742,7 +742,9 @@
if (len == NULL)
die("internal error #1: len is NULL");
if (errs == NULL)
- die("internal error #2: errs in NULL");
+ die("internal error #2: errs is NULL");
+ if (host == NULL)
+ die("internal error #10: host is NULL");
if (D_BUG)
warn("STATUS: obtaining active file from %s", host);
--
Julien ÉLIE
« Oublie les injures, n'oublie jamais les bienfaits. »
More information about the inn-workers
mailing list