Pending patches for INN?

[Julien ÉLIE]

Hi Richard,

>> Regarding your first patch for innxmit, shouldn't
>>    static char *buff;
>> be changed to
>>    static char *buff = NULL;
>> as you no longer use xmalloc, but only xrealloc?
>
> Objects with static storage duration are initialized automatically, in
> this case to a null pointer (C99 6.7.8#10) - so the two lines are
> equivalent.

OK, thanks for the precision.



>> As for actsync.c, maybe we could add the following test at the beginning
>> of get_active()?
>>
>> @@ -742,7 +742,9 @@
>>       if (len == NULL)
>>           die("internal error #1: len is NULL");
>>       if (errs == NULL)
>> -        die("internal error #2: errs in NULL");
>> +        die("internal error #2: errs is NULL");
>> +    if (host == NULL)
>> +        die("internal error #10: host is NULL");
>>       if (D_BUG)
>>           warn("STATUS: obtaining active file from %s", host);
>
> Yes, that wouldn't hurt.

Added, then.
Thanks again.

-- 
Julien ÉLIE

« Oublie les injures, n'oublie jamais les bienfaits. »