Buffindexed page size limited?

Julien ÉLIE julien at trigofacile.com
Sun Jan 7 21:04:19 UTC 2018


Hi Russ,

>> On Fedora 18 ppc64, the overview/api.t test fails with:
> 
>> # buffindexed
>> buffindexed: OV_HDR_PAGESIZE (16384) is not a multiple of pagesize (65536)
>> Opening the overview database failed, cannot continue
>> 
>> So I wonder whether there is a reason for having set OV_HDR_PAGESIZE
>> to 16384 in the buffindexed source code.
>> Couldn't we just set OV_HDR_PAGESIZE to pagesize if pagesize > 16384?
>> This way, it would still work as it used to for existing working systems,
>> and it would also work for systems having pagesize > 16384.
> 
> Very belatedly (more than four years later), I took a look at this and
> concur with this evaluation.  I moved the code around a bit to adapt the
> page size to the the local system page size, hopefully in a way that works
> properly.

Thanks for having taken a look at that issue, and fixed it.
I confirm the buffindexed test suite now works on ppc64 systems.

-- 
Julien ÉLIE

« – Dis Astérix ! Quelle salade pour un peu d'huile !
   – Oui, et dépêchons-nous de trouver un guérisseur avant que ça
     ne tourne au vinaigre. » (Astérix)


More information about the inn-workers mailing list