Please generate the ChangeLog file also for snapshots

Julien ÉLIE julien at trigofacile.com
Thu Jun 11 07:35:35 UTC 2020


Hi Marco,

>> Is it really needed for Debian packages?  (I see that you added a patch to
>> skip its installation if the upstream changelog is missing)
> It is not strictly needed, but I added that workaround expecting that
> this would be solved in a future release.

Each time a release is done, we update Makefile.global.in to bump:
VERSION         = 2.7.0

Maybe we should just add below something like:
CHANGELOG_REV   = 9042

And give that revision number as argument to the script that generates 
the ChangeLog file.  It would then be automatic (no longer prompting for 
a prefix to strip and the date YYYY-MM-DD of the start of ChangeLog).
If of course we decide to keep ChangeLog at all.


>> By the way, thanks for the new Debian package of STABLE 1st June.
> I suggest that you have a look at the systemd integration patch but wait
> to merge it, because socket activation does not work yet with xexec.

https://salsa.debian.org/md/inn2/-/commit/32d4faf47cb0387f42362c0340357b3e3434b74b

In configure.ac:

if pkg-config libsystemd 2> /dev/null; then
    LIBSYSTEMD_LIBS=`pkg-config --libs libsystemd`
    AC_SUBST([LIBSYSTEMD_LIBS])
    AC_DEFINE([HAVE_LIBSYSTEMD], 1, [Define if libsystemd is available.])
fi


When integrating systemd support in INN, we'll use the portable 
RRA_LIB_SYSTEMD_DAEMON_OPTIONAL m4 macro from rra-c-util:

   https://github.com/rra/rra-c-util/blob/master/m4/systemd.m4
   https://github.com/rra/rra-c-util/blob/master/portable/sd-daemon.h




https://salsa.debian.org/md/inn2/-/commit/2cde1af9acaac257ac4fef3cc1ffff1315e80710
"Enable support for Python filters"

In innd/python.c, you should free(path) before returning.



https://salsa.debian.org/md/inn2/-/commit/64a6d34e1956f7133afd6ba132ae469d19a657c0
"Make SIGTERM behave exactly like ctlinnd shutdown"

Should it be merged to upstream?  (OK for me)

-- 
Julien ÉLIE

« Sol lucet omnibus. »


More information about the inn-workers mailing list