modernize innreport HTML

Richard Kettlewell rjk at terraraq.uk
Fri May 15 18:30:21 UTC 2020


On 15/05/2020 19:19, Julien ÉLIE wrote:
> 
> Hi Richard,
> 
>> Without the patch the default behavior does not work properly in modern
>> web server configrations. The embedded CSS is ignored and the embedded
>> images caused a mixed context security warning.
>>
>> Obviously a deployment can fix this up one way or another (in my
>> case, I patch at build time) but I think the generated HTML ought to
>> work "out of the box" rather than requiring operator attention.
> Then why wouldn't we switch the default behaviour to just enable 
> html_css_url in innreport.conf instead of commenting it, and remove 
> legacy inline code for css:
> # html_css_url    "innreport.css";
> 
> innreport.css is already installed by INN in <pathhttp>:
> Makefile -> $D$(PATHHTTP)/innreport.css

You could do that, yes

ttfn/rjk


More information about the inn-workers mailing list