modernize innreport HTML

[Russ Allbery]

Julien ÉLIE <julien at trigofacile.com> writes:

> We already have an external CSS file installed by default (which contains
> the same style as the one that is generated inline):
>   https://inn.eyrie.org/trac/browser/trunk/samples/innreport.css
>   https://inn.eyrie.org/trac/changeset/8170

Oh, that's the bit I'd missed.

> I believe we should just use that innreport.css file by default (instead
> of generating this external CSS file when innreport is run).
> Is there something I am missing?

Nope, that sounds good to me.

> Fresh INN installations will have the new behaviour.
> Updates will keep the legacy behaviour unless they manually enable
> html_css_url in innreport.conf.  Richard's patch permits to force that
> behaviour directly (which is an advantage).  Maybe we should do both
> (change default behaviour and apply Richard's patch).

I suspect that we can skip the part of the patch that constructs the CSS
file and count on the fact that we're shipping a copy, but otherwise doing
both sounds good to me.  I don't think we need to support both inline and
external styles; we can just convert everyone to external styles on
upgrade.

-- 
Russ Allbery (eagle at eyrie.org)             <https://www.eyrie.org/~eagle/>

    Please send questions to the list rather than mailing me directly.
     <https://www.eyrie.org/~eagle/faqs/questions.html> explains why.