modernize innreport HTML
Richard Kettlewell
rjk at terraraq.uk
Sun May 24 11:09:21 UTC 2020
On 24/05/2020 09:27, Julien ÉLIE wrote:
> Here are the 2 patches I've come up with, following your initial
> suggestion and subsequent discussions in the mailing-list:
>
> https://inn.eyrie.org/trac/changeset/10368 (remove W3C links)
> https://inn.eyrie.org/trac/changeset/10374 (CSS externalization)
>
> I've notably added a comment, for future references, to keep old CSS
> definitions for backward compatibility with previously generated reports
> (in case we change HTML structure or style names in future versions).
> Also, automatic generation of innreport.css does not occur if the user
> has a specific CSS of the same name (he would otherwise loose it).
>
>
> Besides, I suggest a change in innreport version numbers. It has been
> "innreport 3.1.0" for a long time, even though modifications were
> carried. A wording like "innreport from INN 2.6.4" (incrementing with a
> new release) makes it clearer:
>
> https://inn.eyrie.org/trac/changeset/10371
>
>
> If you have any comment, do not hesitate to tell.
> I'll commit these patches in a few days to the stable branch (for INN
> 2.6.4) if that's OK for everyone.
All looks good to me!
ttfn/rjk
More information about the inn-workers
mailing list