[PATCH] drop unused filterPath

Dominik 'Rathann' Mierzejewski dominik at greysector.net
Fri Sep 11 16:34:27 UTC 2020


Hello, Julien!

On Friday, 11 September 2020 at 15:06, Julien ÉLIE wrote:
> Hi Dominik,
> 
> > (.text+0x0): multiple definition of `filterPath'; art.o (symbol from plugin):(.text+0x0): first defined here
> >
> > Upon further inspection, it seems that filterPath is declared in both
> > innd/art.c:81 and innd/python.c:63 (without const), set in
> > innd/art.c:2076, but never used. Shall we drop it, then? Patch attached.
> 
> Yes, exactly.  Latest version of GCC triggers that warning.
> Patch already present upstream (will be shipped with INN 2.6.4):
>   https://inn.eyrie.org/trac/changeset/10361

Great! I have some more patches from Fedora package lined up for
submission. I'll post them here as time permits. I'll have to dig up the
rationale behind their existence, too, as they were created by previous
maintainers.

Regards,
Dominik
-- 
Fedora   https://getfedora.org  |  RPM Fusion  http://rpmfusion.org
There should be a science of discontent. People need hard times and
oppression to develop psychic muscles.
        -- from "Collected Sayings of Muad'Dib" by the Princess Irulan


More information about the inn-workers mailing list