nnrpd: adding blacklistd support

[Andreas Kempe]

Hello Julien,

On Sun, Mar 27, 2022 at 11:49:15PM +0200, Julien ÉLIE wrote:
> Hi Andreas,
> 
> > FreeBSD ships the software blacklistd, originally from NetBSD, that
> > allows blocking brute force attacks using the firewall. I've written a
> > small patch running on Lysator's news server adding support to nnrpd
> > for automatic blocking.
> > 
> > I'm writing this to probe whether there is any interest in having the
> > patch upstreamed. In its current form, the blacklist code is
> > unconditionally added but can of course be put behind an option to the
> > configure script or a FreeBSD define of some kind.
> > 
> > See the attached file for the patch.
> 
> Thanks for the patch.  I've had a look, and it seems that the 
> integration of blacklistd is pretty straight-forward.
> I think it deserves being integrated into INN, with a proper 
> --with-blacklistd Autoconf probe (instead of an error if blacklistd is 
> not found). 

Adding it as --with-blacklistd sounds like the right thing to do, yes. 

> I'll have a look.  As I do not run FreeBSD myself, it would 
> be great if you could somehow test it.
> 

When you say that you will have a look, does that mean that you want
to rework the patch yourself?

I'm willing (and was expecting) to open a pull request on GitHub and
do testing as well as any required rewriting per your review. If you
want to do the work I'm of course willing to test any changes you make
on Lysator's server.

Cordially,
Andreas Kempe