makehistory can generate duplicate lines

[Kamil Jońca]

Kamil Jońca <kjonca at op.pl> writes:

> Kamil Jońca <kjonca at op.pl> writes:
>
> [....]
>>
>> I applied both patches to debian sources, and I am runnning this
>> server.
>> Nothing exploded, seems to work.
>>
>> --8<---------------cut here---------------start------------->8---
>> sudo -u news env PATH=$PATH:/usr/lib/news/bin makehistory -O -x -S 
>> --8<---------------cut here---------------end--------------->8---
>>
>> creates no duplicates.
>>
>> Effect of
>>
>> --8<---------------cut here---------------start------------->8---
>> sudo -u news env PATH=$PATH:/usr/lib/news/bin makehistory -f history.n
>> --8<---------------cut here---------------end--------------->8---
>
> But I am almost sure that this is still something wrong with
> makehistory/cnfs code.
> It is not understandable for me that first article during scanning spool
> has different cycle number than others. (On fully wrapped buffer)
> Maybe I am missed something.
> KJ
Hm.

--8<---------------cut here---------------start------------->8---
    token = CNFSMakeToken(cycbuff->name, offset, cycbuff->blksz,
                          (offset > cycbuff->free) ? cycbuff->cyclenum - 1
                                                   : cycbuff->cyclenum,
                          cah.class);
--8<---------------cut here---------------end--------------->8---

I think this might be interesting part, especially "offset >
cycbuff->free" condition, (maybe "=>" inequality?), but this is probably
far shot.

KJ

-- 
http://stopstopnop.pl/stop_stopnop.pl_o_nas.html