[PATCH 1/2] storage: Add "filtered" option, to store based on the filter's decision

[Julien ÉLIE]

Hi Christoph,

> @@ -643,6 +653,7 @@ SMgetsub(const ARTHANDLE article)
>               && (!sub->maxsize || (article.len <= sub->maxsize))
>               && (!sub->minexpire || article.expires >= sub->minexpire)
>               && (!sub->maxexpire || (article.expires <= sub->maxexpire))
> +             && (sub->filtered == article.filtered)
>               && MatchGroups(article.groups, article.groupslen, sub->pattern,
>                              sub->exactmatch)) {
>               if (InitMethod(typetoindex[sub->type]))

When dontrejectfiltered is set in inn.conf, I am under the impression 
that the above additional condition will break storage for people who do 
not use the filtered parameter.
If I do not have the new filtered parameter set on any storage class, 
then filtered articles will no longer be stored ("no matching entry in 
storage.conf").

I am unsure how to best deal with that.
If no storage class has a filtered parameter, fall back to discard that 
condition?

Or consider that using dontrejectfiltered implies the use of the 
filtered parameter in storage.conf, and then it would be a change to 
delay for a major release (INN 2.8.0).  Yet, I would prefer not to 
correlate the two settings, and allow news admins to use 
dontrejectfiltered without having to fiddle with the filtered parameter.

-- 
Julien ÉLIE

« Si bene commemini, causae sunt quinque bibendi : Hospitis aduentus,
   praesens sitis atque futura, Et uini bonitas, et quaelibet altera
   causa. »