[PATCH] Junos output contains NULL bytes

[Nick Hilliard]

Hi Faidon,

On 02/07/2009 15:13, Faidon Liambotis wrote:
> [I tried reporting this on Trac but both preview and submit were timing
> out, while the rest of the site works]

Are you using ipv6 to connect to irrtoolset.isc.org?  I have had trouble 
like this previously on ipv6.

> It seems that rtconfig's output for Junos results in some NULL bytes
> spanning in various lines of the output which effectively makes the
> output unsuitable for use.

ah, you mean nul octets.  NULL is a void pointer, usually (void *)0; nul is \0.

> The attached patch fixes this bug; please carefully review, I think it
> shouldn't introduce any buffer overflows but I can easily be wrong.

Yep, looks like it's generating garbage.  I'll take a look at the patch 
later and see what it's doing.  Unfortunately, i don't have any junipers to 
test this output on.

Nick