<div dir="ltr">Was not pestering, just wanted to know where to put my stuff. Regarding that, I've decided to change the 3 Cassandra PRs and I've just finished. Also added a couple of other PRs. Hope you find them as exciting as I did. Wrote explanations in the commit messages. I have more, but it's tiresome work so in order to triage, whenever you're available, could you please tell me which of these additions could be of interest to you? A simple <b>yes</b>/<b>no</b> would do.<div><ol><li><b>mulithread </b>processing of packets (thread-safe for Cassandra, would require additional work for MySql and PostgreSql): 8x lease allocations on limited hardware</li><li><b>tools/<a href="http://defines-resolver.sh.in" target="_blank">defines-resolver.sh.in</a></b>: allows #ifdef blocks in any file with seamless integration in automake, we used <b>#ifdef</b>s in scripts.</li><li>add <b>--nonet</b> back to <b>xsltproc</b> commands in Makefiles, they force cache usage and greatly improve speed, I may have wrongfully and unknowledgeably removed them</li><li><b>kea-admin</b> commands: <b>db-create</b>, <b>db-remove</b>, <b>create-db-and-users</b> (for unit-tests: keatest DB, read-only permissions, other annoyingly hard setups),<b> lease-drop</b></li><li><b>clang-tidy</b> integration with automake (Kea does have cppcheck, although not currently working, see "various changes to Makefile.am" PR for a fix, but maybe another linter wouldn't hurt?)</li><li><b>--pedantic</b> flag alongside -Werror; in Kea, it yields only the following warnings (which is impressive):</li><ul><li> extra ‘;’<br></li><li> ISO C++ forbids zero-size array<br></li><li> overflow in implicit constant conversion<br></li></ul></ol><div>They are all done in our copy of the code. I would just have to migrate.</div><div>Also, I'm aware of "<b>Initialize logging before reading configuration" </b>having an issue. Will give it a try soon.</div><div><br></div><div>Thank you for your time,</div><div>Andrei</div><div><br></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 18, 2017 at 6:01 PM, Thomas Markwalder <span dir="ltr"><<a href="mailto:tmark@isc.org" target="_blank">tmark@isc.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"><div><div class="h5">
<div class="m_-64281939653316601moz-cite-prefix">On 8/17/17 9:19 AM, Andrei Pavel wrote:<br>
</div>
</div></div><blockquote type="cite"><div><div class="h5">
<div dir="ltr">Hello ISC,
<div><br>
</div>
<div>There are a few pull requests I made some time ago.I will
be attempting to update them and solve any of their
showstoppers by the end of the month.</div>
<div><br>
</div>
<div>Before that, I will be preparing several other pull
requests. Some of them are updates to everything <b>Cassandra</b>-related.
These are major changes and probably the last of such
grandeur. They include replacing the Cassandra data types from
<b>void*</b> to <b>boost::any</b> (thus solving <a href="http://kea.isc.org/ticket/4525" target="_blank">trac4525</a> [1])
and migrating stress tests to <b>google benchmark</b> (which
is where they belong) along with the integration of google
benchmark in <b>Kea</b>. I can quickly conjure a full
changelog beforehand if necessary.</div>
<div><br>
</div>
<div>These changes can be mapped perfectly to the existing 3
PRs. I would prefer mapping them as such since it halves your
reviewing effort. My question is, do I mess up any current
review progress if I amend them?</div>
<div>
<div><br>
</div>
<div>[1] <a href="http://kea.isc.org/ticket/4525" target="_blank">http://kea.isc.org/ticket/4525</a></div>
<div><br>
</div>
-- <br>
<div class="m_-64281939653316601gmail_signature">
<div dir="ltr">
<div>
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<table width="100%">
<tbody>
<tr>
<td>
<table>
<tbody>
<tr>
<td>andrei pavel</td>
<td width="2"><br>
</td>
<td>
<table>
<tbody>
<tr>
<td><img alt="qualitance.com"></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</td>
</tr>
<tr>
<td>junior c++ developer</td>
</tr>
<tr>
<td><a href="tel:+40+%28748%29+220+135" target="_blank">+40
(748) 220 135</a>, <a href="https://www.qualitance.com/" target="_blank">qualitance.com</a></td>
</tr>
</tbody>
</table>
<table>
<tbody>
<tr>
<td><br>
</td>
</tr>
</tbody>
</table>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<fieldset class="m_-64281939653316601mimeAttachmentHeader"></fieldset>
<br>
</div></div><pre>______________________________<wbr>_________________
kea-dev mailing list
<a class="m_-64281939653316601moz-txt-link-abbreviated" href="mailto:kea-dev@lists.isc.org" target="_blank">kea-dev@lists.isc.org</a>
<a class="m_-64281939653316601moz-txt-link-freetext" href="https://lists.isc.org/mailman/listinfo/kea-dev" target="_blank">https://lists.isc.org/mailman/<wbr>listinfo/kea-dev</a></pre>
</blockquote>
<p>Duly noted. We aren't ignoring you we just have a lot of staff
on vacation this week.</p>
<p>Regards,</p>
<p>Thomas Markwalder</p>
<p>ISC Software Engineering<br>
</p>
</div>
<br>______________________________<wbr>_________________<br>
kea-dev mailing list<br>
<a href="mailto:kea-dev@lists.isc.org">kea-dev@lists.isc.org</a><br>
<a href="https://lists.isc.org/mailman/listinfo/kea-dev" rel="noreferrer" target="_blank">https://lists.isc.org/mailman/<wbr>listinfo/kea-dev</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><table cellpadding="0" cellspacing="0" width="100%" style="border-collapse:collapse;border-spacing:0px;background:0px 0px;max-width:100%;border:none;margin:0px;padding:0px;vertical-align:middle;outline:0px;color:rgb(129,129,129);font-family:Lato,sans-serif;font-size:18px"><tbody style="background:0px 0px;border:0px;margin:0px;padding:0px;vertical-align:baseline;outline:0px"><tr style="background:0px 0px;border:0px;margin:0px;padding:0px;vertical-align:baseline;outline:0px"><td style="padding:0px;background:0px 0px;border:0px;vertical-align:middle;outline:0px"><table cellpadding="0" cellspacing="0" style="border-collapse:collapse;border-spacing:0px;background:0px 0px;max-width:100%;border:none;margin:0px;padding:0px;vertical-align:middle;outline:0px"><tbody style="background:0px 0px;border:0px;margin:0px;padding:0px;vertical-align:baseline;outline:0px"><tr style="background:0px 0px;border:0px;margin:0px;padding:0px;vertical-align:baseline;outline:0px"><td style="padding:2px 5px 2px 0px;background:0px 0px;border:0px;vertical-align:middle;outline:0px;font-family:Lato,sans-serif;font-weight:700;line-height:22px;color:rgb(0,0,0);letter-spacing:0.6px">andrei pavel</td><td width="2" style="padding:0px;background:0px 0px;border:0px;vertical-align:middle;outline:0px"></td><td style="padding:0px;background:0px 0px;border:0px;vertical-align:middle;outline:0px"><table cellpadding="0" cellspacing="0" style="border-collapse:collapse;border-spacing:0px;background:0px 0px;max-width:100%;border:none;margin:0px;padding:0px;vertical-align:middle;outline:0px"><tbody style="background:0px 0px;border:0px;margin:0px;padding:0px;vertical-align:baseline;outline:0px"><tr style="background:0px 0px;border:0px;margin:0px;padding:0px;vertical-align:baseline;outline:0px"><td style="padding:0px;background:0px 0px;border:0px;vertical-align:middle;outline:0px"><img src="https://d1lnc6p59d57mi.cloudfront.net/Signature/qsignature-icon.png" alt="qualitance.com" style="border:0px;vertical-align:middle;max-width:100%;height:auto"></td></tr></tbody></table></td></tr></tbody></table></td></tr><tr style="background:0px 0px;border:0px;margin:0px;padding:0px;vertical-align:baseline;outline:0px"><td style="padding:0px 0px 2px;background:0px 0px;border:0px;vertical-align:middle;outline:0px;font-family:Lato,sans-serif;font-size:12px;line-height:16px;letter-spacing:1px;color:rgb(0,0,0)">junior c++ developer</td></tr><tr style="background:0px 0px;border:0px;margin:0px;padding:0px;vertical-align:baseline;outline:0px"><td style="padding:3px 0px 1px;background:0px 0px;border:0px;vertical-align:middle;outline:0px;font-family:Lato,sans-serif;font-size:12px;line-height:16px;color:rgb(0,0,0)"><a href="tel:+40+(748)+220+135" style="background:0px 0px;color:rgb(0,0,0);outline:0px;border:0px;margin:0px;padding:0px;vertical-align:baseline;line-height:16px;letter-spacing:0.6px" target="_blank">+40 (748) 220 135</a>, <a href="https://www.qualitance.com/" style="background:0px 0px;color:rgb(0,0,0);outline:0px;border:0px;margin:0px;padding:0px;vertical-align:baseline;line-height:16px;letter-spacing:0.6px" target="_blank">qualitance.com</a></td></tr></tbody></table><table style="font-family:'Times New Roman';margin:0px;padding:0px;border:0px;color:rgb(51,51,51)"><tbody><tr><td style="font-stretch:normal;font-size:9px;font-family:Verdana;color:rgb(153,153,153)"></td></tr></tbody></table></div></div></div></div></div></div></div>
</div>