[Kea-users] keama-leases.py fails with abandoned leases

John Lind steinhelten at gmail.com
Sat Feb 15 23:32:19 UTC 2025 

Where would I find the documentation on what an abandoned lease should look
like in the kea leases file?  Maybe I can make a better fix.

On Fri, Feb 7, 2025 at 3:29 AM Darren Ankney <darren.ankney at gmail.com>
wrote:

> Hi John,
>
> "May not work" was probably the wrong phrase.  It may not provide all
> necessary functionality might have been better.  The abandoned leases
> are because of DHCPDECLINE.  Kea has a similar concept.  I'm not sure
> exactly how those are recorded in the lease file by Kea.  If the team
> would want to save these when importing the leases, more work might be
> required, was what I really meant.
>
> Thank you,
> Darren Ankney
>
> On Thu, Feb 6, 2025 at 5:18 PM John Lind <steinhelten at gmail.com> wrote:
> >
> > Awesome!  Thank you so much!  I'm confused about it saying the patch
> "may not work" - it certainly worked in my test case, although perhaps it
> means "it may not work in all cases" which could certainly be true - but I
> don't think that the assumption that we should be able to discard any lease
> that lacks a "hardware ethernet" from isc dhcp is a bad starting point,
> because that's what it actually does.
> >
> > On Thu, Feb 6, 2025 at 3:41 PM Darren Ankney <darren.ankney at gmail.com>
> wrote:
> >>
> >> Hi John,
> >>
> >> Someone has reported for you:
> >> https://gitlab.isc.org/isc-projects/keama/-/issues/70
> >>
> >> Have a great week!
> >>
> >> Thank you,
> >> Darren Ankney
> >>
> >> On Thu, Feb 6, 2025 at 2:55 PM John Lind <steinhelten at gmail.com> wrote:
> >> >
> >> > Thanks, Darren.  I'm retired now, and don't really have a way to get
> another email address that wouldn't also be some sort of "public" server.
> Also, I'm hoping that this is going to be a "one and done" for me - I don't
> expect to be a regular contributor, and won't meet the participation
> requirements of the site.
> >> >
> >> > I downloaded the file from the link you provided, and that's how I
> originally got it, and it's still identical to what I started with.
> >> >
> >> > I see that you are also using a "@gmail.com" address, so perhaps you
> wouldn't be able to help me, either, but I'm hoping that SOMEONE on this
> list would pick up this literal 2-line mod and commit it to the project.
> Perhaps they would need to create an issue first - I'm not quite sure what
> the work-flow is here.  The change definitely solves a real-world problem.
> >> >
> >> > On Thu, Feb 6, 2025 at 7:39 AM Darren Ankney <darren.ankney at gmail.com>
> wrote:
> >> >>
> >> >> Hi John,
> >> >>
> >> >> The latest version of this file should be here:
> >> >>
> https://gitlab.isc.org/isc-projects/keama/-/blob/master/leases/keama-leases.py
> >> >>
> >> >> You can create an account on https://gitlab.isc.org/users/sign_up
> but
> >> >> I think you can't use an @gmail.com address (or other public free
> >> >> email provider address) to do so (due to spam).
> >> >>
> >> >> Once you've been able to create an account, it should be no problem
> >> >> for you to open an issue here:
> >> >> https://gitlab.isc.org/isc-projects/keama/-/issues where you can
> >> >> attach your patch in whatever way you see fit.  I don't think you'll
> >> >> be able to actually create a merge request though.
> >> >>
> >> >> Thank you,
> >> >> Darren Ankney
> >> >>
> >> >> On Mon, Feb 3, 2025 at 10:57 PM John Lind <steinhelten at gmail.com>
> wrote:
> >> >> >
> >> >> > I managed to pull the script from the GIT repository.  It doesn't
> seem to be versioned, but I believe it is the latest and it says:
> >> >> >
> >> >> > # dhcp2kea by marmo
> >> >> > # 6-12-2022 (dhcpd4), 14-12-2022 (dhcpd6), 15-12-2022
> (dhcp2kea.php)
> >> >> > # 23-12-2022 ("addr key=value" option)
> >> >> >
> >> >> > It seems to work great on my "leases" file, EXCEPT for the entries
> that are abandoned, e.g.
> >> >> > lease 192.168.1.43 {
> >> >> >         starts 0 2023/12/17 00:15:52 UTC;
> >> >> >         ends 2 2024/01/16 00:15:52 UTC;
> >> >> >
> >> >> >         abandoned;
> >> >> > }
> >> >> >
> >> >> > Then it says,
> >> >> >
> >> >> > root at remo:/home/john/xfer # python3 keama-leases.py dhcpd.leases
> >> >> > Traceback (most recent call last):
> >> >> >   File "/home/john/xfer/keama-leases.py", line 329, in <module>
> >> >> >     print(leases,file=f)  # writing
> >> >> >     ^^^^^^^^^^^^^^^^^^^^
> >> >> >   File "/home/john/xfer/keama-leases.py", line 105, in __str__
> >> >> >     , v["hardware ethernet"] # hwaddr
> >> >> >       ~^^^^^^^^^^^^^^^^^^^^^
> >> >> > KeyError: 'hardware ethernet'
> >> >> >
> >> >> > This is not a show stopper for me, because I can just edit out
> those half-dozen or so entries and then it seems to work fine (though I
> haven't tried importing the .csv file into a mem file - not that far yet -
> or maybe this IS the format of the mem file?) but since this is a perfectly
> legitimate entry from isc-dhcpd, I'm wondering if a fix might not be in
> order?  I'm guessing that it should be fairly simple to test for the
> existence of that key and skip the entry, but I'm not a python person (perl
> rules!) so I don't feel fully confident in trying to fix this.  If I' the
> best available candidate, I'm willing to take a run at it.
> >> >> >
> >> >> > Actually, I did just take a swing at it.  It was easy.
> >> >> >
> >> >> > root at remo:/home/john/xfer # diff keama-leases.py
> keama-leases-fix.py
> >> >> > 96a97,98
> >> >> > >             if "hardware ethernet" not in v:
> >> >> > >                 continue
> >> >> >
> >> >> > Can someone help me commit this to git?
> >> >> >
> >> >> > --
> >> >> > John Lind
> >> >> > steinhelten at gmail.com
> >> >> >
> >> >> > --
> >> >> > ISC funds the development of this software with paid support
> subscriptions. Contact us at https://www.isc.org/contact/ for more
> information.
> >> >> >
> >> >> > To unsubscribe visit
> https://lists.isc.org/mailman/listinfo/kea-users.
> >> >> >
> >> >> > Kea-users mailing list
> >> >> > Kea-users at lists.isc.org
> >> >> > https://lists.isc.org/mailman/listinfo/kea-users
> >> >> --
> >> >> ISC funds the development of this software with paid support
> subscriptions. Contact us at https://www.isc.org/contact/ for more
> information.
> >> >>
> >> >> To unsubscribe visit
> https://lists.isc.org/mailman/listinfo/kea-users.
> >> >>
> >> >> Kea-users mailing list
> >> >> Kea-users at lists.isc.org
> >> >> https://lists.isc.org/mailman/listinfo/kea-users
> >> >
> >> > --
> >> > ISC funds the development of this software with paid support
> subscriptions. Contact us at https://www.isc.org/contact/ for more
> information.
> >> >
> >> > To unsubscribe visit https://lists.isc.org/mailman/listinfo/kea-users
> .
> >> >
> >> > Kea-users mailing list
> >> > Kea-users at lists.isc.org
> >> > https://lists.isc.org/mailman/listinfo/kea-users
> >> --
> >> ISC funds the development of this software with paid support
> subscriptions. Contact us at https://www.isc.org/contact/ for more
> information.
> >>
> >> To unsubscribe visit https://lists.isc.org/mailman/listinfo/kea-users.
> >>
> >> Kea-users mailing list
> >> Kea-users at lists.isc.org
> >> https://lists.isc.org/mailman/listinfo/kea-users
> >
> > --
> > ISC funds the development of this software with paid support
> subscriptions. Contact us at https://www.isc.org/contact/ for more
> information.
> >
> > To unsubscribe visit https://lists.isc.org/mailman/listinfo/kea-users.
> >
> > Kea-users mailing list
> > Kea-users at lists.isc.org
> > https://lists.isc.org/mailman/listinfo/kea-users
> --
> ISC funds the development of this software with paid support
> subscriptions. Contact us at https://www.isc.org/contact/ for more
> information.
>
> To unsubscribe visit https://lists.isc.org/mailman/listinfo/kea-users.
>
> Kea-users mailing list
> Kea-users at lists.isc.org
> https://lists.isc.org/mailman/listinfo/kea-users
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.isc.org/pipermail/kea-users/attachments/20250215/f47b60ad/attachment-0001.htm>

More information about the Kea-users mailing list