<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style>
body {
font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
padding:1em;
margin:auto;
background:#fefefe;
}
h1, h2, h3, h4, h5, h6 {
font-weight: bold;
}
h1 {
color: #000000;
font-size: 28pt;
}
h2 {
border-bottom: 1px solid #CCCCCC;
color: #000000;
font-size: 24px;
}
h3 {
font-size: 18px;
}
h4 {
font-size: 16px;
}
h5 {
font-size: 14px;
}
h6 {
color: #777777;
background-color: inherit;
font-size: 14px;
}
hr {
height: 0.2em;
border: 0;
color: #CCCCCC;
background-color: #CCCCCC;
display: inherit;
}
p, blockquote, ul, ol, dl, li, table, pre {
margin: 15px 0;
}
a, a:visited {
color: #4183C4;
background-color: inherit;
text-decoration: none;
}
#message {
border-radius: 6px;
border: 1px solid #ccc;
display:block;
width:100%;
height:60px;
margin:6px 0px;
}
button, #ws {
font-size: 12 pt;
padding: 4px 6px;
border-radius: 5px;
border: 1px solid #bbb;
background-color: #eee;
}
code, pre, #ws, #message {
font-family: Monaco;
font-size: 10pt;
border-radius: 3px;
background-color: #F8F8F8;
color: inherit;
}
code {
border: 1px solid #EAEAEA;
margin: 0 2px;
padding: 0 5px;
}
pre {
border: 1px solid #CCCCCC;
overflow: auto;
padding: 4px 8px;
}
pre > code {
border: 0;
margin: 0;
padding: 0;
}
#ws { background-color: #f8f8f8; }
.bloop_markdown table {
border-collapse: collapse;
font-family: Helvetica, arial, freesans, clean, sans-serif;
color: rgb(51, 51, 51);
font-size: 15px; line-height: 25px;
padding: 0; }
.bloop_markdown table tr {
border-top: 1px solid #cccccc;
background-color: white;
margin: 0;
padding: 0; }
.bloop_markdown table tr:nth-child(2n) {
background-color: #f8f8f8; }
.bloop_markdown table tr th {
font-weight: bold;
border: 1px solid #cccccc;
margin: 0;
padding: 6px 13px; }
.bloop_markdown table tr td {
border: 1px solid #cccccc;
margin: 0;
padding: 6px 13px; }
.bloop_markdown table tr th :first-child, table tr td :first-child {
margin-top: 0; }
.bloop_markdown table tr th :last-child, table tr td :last-child {
margin-bottom: 0; }
.bloop_markdown blockquote{
border-left: 4px solid #dddddd;
padding: 0 15px;
color: #777777; }
blockquote > :first-child {
margin-top: 0; }
blockquote > :last-child {
margin-bottom: 0; }
code, pre, #ws, #message {
word-break: normal;
word-wrap: normal;
}
hr {
display: inherit;
}
.bloop_markdown :first-child {
-webkit-margin-before: 0;
}
code, pre, #ws, #message {
font-family: Menlo, Consolas, Liberation Mono, Courier, monospace;
}
.send { color:#77bb77; }
.server { color:#7799bb; }
.error { color:#AA0000; }</style>
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
<div class="bloop_markdown">
<p>Documentation wouldn’t be too difficult:</p>
<blockquote>
<p>When the <code>data</code> field is a <code>string</code>, and that string contains the comma (<code>,</code>; U+002C) character, the comma must be escaped with a two reverse solidus characters (<code>\\</code>; U+005C). For example, the string
<code>foo,bar</code> would be <code>foo\\,bar</code>.</p>
</blockquote>
<p>However, I’m not sure that escaping is the best route. It is clear to me that the problem stems from the fact that the
<code>data</code> property can either only be a CSV value or a binary value. My suggestion for a more robust fix would be to remove the
<code>csv-format</code> property and replace it with a <code>format</code> property. The new
<code>format</code> property could accept the string values: ‘csv’, ‘binary’, or ‘literal’. The default could remain ‘csv’, and the case under discussion would be ‘literal’. This would also provide the possibility for other value types in the future.</p>
<p></p>
</div>
<div class="bloop_original_html"><style>body{font-family:Helvetica,Arial;font-size:13px}</style>
<div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;">
<br>
</div>
<br>
<div id="bloop_sign_1485869279786215936" class="bloop_sign"></div>
<br>
<p class="airmail_on">On January 31, 2017 at 6:42:36 AM, Francis Dupont (<a href="mailto:fdupont@isc.org">fdupont@isc.org</a>) wrote:</p>
<blockquote type="cite" class="clean_bq"><span>
<div>
<div></div>
<div>As Vicky said in another response the ticket is under review so it will <br>
be merged before the 1.2 release but the delay from today is only bounded <br>
(I have no control on it as I wrote the patch so I may not review it too). <br>
I pushed the trac5105 branch on github so you can take it. There is only <br>
one commit so it is easy to make a patch from it and to apply it to <br>
Kea 1.1 sources. I am checking it: patch succeeded with different offsets <br>
(not a problem: this just means some files have changed since 1.1). <br>
I am running a full check and I expect it will be successful. <br>
An important detail: to not be misinterpreted as a field separator <br>
commas must be escaped. The escape character is the backslash \ which <br>
is also the escape one for JSON and C++ so to put foo,bar into an <br>
option data string value you have to use "data": "foo\\,bar" <br>
(and in C++ examples this becomes \"data\": \"foo\\\\,bar\" in <br>
the case you read the patch content). <br>
BTW something I expect from the reviewer is a request for documentation <br>
so if you have an idea about to explain the escape feature in the Kea <br>
user guide... <br>
<br>
Regards <br>
<br>
Francis Dupont <fdupont@isc.org> <br>
<br>
PS: to clone the github repository: <br>
git clone https://github.com/isc-projects/kea.git <br>
<br>
if you already have a clone, don't forget to pull it and to checkout master. <br>
To get the patch: <br>
git diff ...origin/trac5105 > trac5105.diff <br>
<br>
To apply the patch go to your kea sources and: <br>
patch -p1 < trac5105.diff <br>
<br>
And build kea... <br>
</div>
</div>
</span></blockquote>
</div>
<div class="bloop_markdown">
<p></p>
</div>
</body>
</html>