Couple of 8.2.2-P5 relative patches for statistics gathering...

Brad Knowles blk at skynet.be
Mon Mar 6 11:48:34 UTC 2000


Folks,

	We've run into a couple of things over here with regards to the 
way BIND collects and reports statistics, and have made a couple of 
minor modifications (patch below).


	It is my understanding that in BIND 8.2.2-P5, RcvdFwdQ was only 
being updated if the option "host-statistics" was set, which appears 
to be a change from 4.9.x (where this option didn't exist at all). 
It also appears to me like this is unlike the other values that are 
being updated regardless of this option.

	We also noted that the "SAns" counter is never updated when 
forwarding a reponse to the original requeste, and is only updated 
when the answer is found from local cache.  It seems to us that this 
counter should be updated in either event.


	If the intention is to refuse these patches, I'd very much like 
to understand the reasoning behind that decision -- perhaps it would 
help us better understand what our clients and servers are doing, and 
how we can change our code to more properly capture these events.


	Thanks!



--- bind-8.2.2p5.orig/src/bin/named/ns_forw.c.orig	Wed Oct 13 18:39:07 1999
+++ bind-8.2.2p5.orig/src/bin/named/ns_forw.c	Mon Mar  6 09:47:27 2000
@@ -288,8 +288,7 @@
  		hp = (HEADER *) qp->q_msg;
  	}

-	if (NS_OPTION_P(OPTION_HOSTSTATS))
-		nameserIncr(from.sin_addr, nssRcvdFwdQ);
+	nameserIncr(from.sin_addr, nssRcvdFwdQ);
  	nameserIncr(nsa->sin_addr, nssSentFwdQ);
  	if (qpp)
  		*qpp = qp;

--- bind-8.2.2p5.orig/src/bin/named/ns_resp.c.orig	Fri Nov  5 05:40:57 1999
+++ bind-8.2.2p5.orig/src/bin/named/ns_resp.c	Mon Mar  6 09:46:23 2000
@@ -1560,6 +1560,11 @@
   return_msg:
  	nameserIncr(from.sin_addr, nssRcvdFwdR);
  	nameserIncr(qp->q_from.sin_addr, nssSentFwdR);
+	nameserIncr(qp->q_from.sin_addr, nssSentAns);
+	if (!hp->aa)
+		nameserIncr(qp->q_from.sin_addr, nssSentNaAns);
+	if (hp->rcode == NXDOMAIN)
+		nameserIncr(qp->q_from.sin_addr, nssSentNXD);
  	/* The "standard" return code */
  	hp->qr = 1;
  	hp->id = qp->q_id;

-- 
  These are my opinions and should not be taken as official Skynet policy
=========================================================================
Brad Knowles, <blk at skynet.be>       Sys. Arch., Mail/News/FTP/Proxy Admin

Note: No Microsoft programs were used in the creation or distribution of
this message. If you are using a Microsoft program to view this message,
be forewarned that I am not responsible for any harm you may encounter as
a result.

See <http://i-want-a-website.com/about-microsoft/twelve-step.html> for
details.



More information about the bind-workers mailing list